- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.6k
 
[py] implement configurable configuration class for the http client #13286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##            trunk   #13286      +/-   ##
==========================================
- Coverage   58.48%   58.30%   -0.18%     
==========================================
  Files          86       89       +3     
  Lines        5270     5430     +160     
  Branches      220      224       +4     
==========================================
+ Hits         3082     3166      +84     
- Misses       1968     2040      +72     
- Partials      220      224       +4     ☔ View full report in Codecov by Sentry.  | 
    
7696a64    to
    923208f      
    Compare
  
    | 
           I had a circular dependency so I removed all references to Proxy from RemoteConnection and am calculating   | 
    
923208f    to
    a57423a      
    Compare
  
    
          CI Failure Feedback 🧐(Checks updated until commit 3dd1b39)
 ✨ CI feedback usage guide:The CI feedback tool ( 
 In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where  Configuration options
 See more information about the   | 
    
26b1978    to
    8c0a61c      
    Compare
  
    Signed-off-by: Viet Nguyen Duc <[email protected]>
8c0a61c    to
    3d209cb      
    Compare
  
    448437d    to
    3cc35c8      
    Compare
  
    Signed-off-by: Viet Nguyen Duc <[email protected]>
3cc35c8    to
    9f21342      
    Compare
  
    Signed-off-by: Viet Nguyen Duc <[email protected]> # Conflicts: # py/selenium/webdriver/remote/remote_connection.py # py/selenium/webdriver/remote/webdriver.py
6aedd22    to
    d6c8b0d      
    Compare
  
    | 
           @KazuCocoa, @navin772, can you please review this, since there is something relates to #14587  | 
    
d6c8b0d    to
    6147a29      
    Compare
  
            
          
                py/test/unit/selenium/webdriver/remote/remote_connection_tests.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      6147a29    to
    6087134      
    Compare
  
    Signed-off-by: Viet Nguyen Duc <[email protected]>
6087134    to
    3dd1b39      
    Compare
  
    
Description
init_args_for_pool_manager)init_args_for_pool_manager)Motivation and Context
Still need to implement: